Refactor workflow to properly wait for migrations #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
cypress failed
Passing run #1229 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
github-actions
bot
added
cypress passed
and removed
cypress failed
sainak
approved these changes
Sep 12, 2023
rithviknishad
approved these changes
Sep 12, 2023
khavinshankar
approved these changes
Sep 12, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 43305da
Improved the reliability and speed of the cypress workflow by separating the steps of starting the
careservice and loading dummy data. Used a custom action to wait for the migrations to finish before proceeding.This pull request introduces an important enhancement to the Docker setup script. Previously, the script used a fixed sleep time to wait for the database migrations to complete before loading the dummy data. This approach was not reliable because the actual time required for the migrations can vary.
The updated script now dynamically waits for all database migrations to be applied before proceeding to load the dummy data. This is achieved by continuously checking for any unapplied migrations every 5 seconds, and once all migrations have been applied, the script proceeds to load the dummy data.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 43305da